pinot icon indicating copy to clipboard operation
pinot copied to clipboard

[Draft] [multistage] Add Partitioning Keys for Table Scan Node

Open ankitsultana opened this issue 3 years ago • 3 comments

cc: @walterddr

ankitsultana avatar Sep 13 '22 09:09 ankitsultana

Codecov Report

Merging #9388 (537951d) into master (6a5fd21) will decrease coverage by 43.67%. The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #9388       +/-   ##
=============================================
- Coverage     69.79%   26.11%   -43.68%     
+ Complexity     4710       44     -4666     
=============================================
  Files          1885     1873       -12     
  Lines        100416   100078      -338     
  Branches      15280    15245       -35     
=============================================
- Hits          70085    26136    -43949     
- Misses        25375    71313    +45938     
+ Partials       4956     2629     -2327     
Flag Coverage Δ
integration1 26.11% <0.00%> (+0.02%) :arrow_up:
integration2 ?
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...requesthandler/MultiStageBrokerRequestHandler.java 67.04% <ø> (ø)
.../java/org/apache/pinot/query/QueryEnvironment.java 0.00% <0.00%> (-82.15%) :arrow_down:
...ache/pinot/query/planner/logical/StagePlanner.java 0.00% <0.00%> (-93.86%) :arrow_down:
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) :arrow_down:
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) :arrow_down:
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) :arrow_down:
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 1365 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 13 '22 09:09 codecov-commenter

Is the overall purpose of this PR to wire the JOIN planning of co-located JOIN for partitioned tables (the placement being worked in https://github.com/apache/pinot/pull/9199) ?

If so, I don't think the changes are complete. We need to remove the exchanges to avoid data movement. Also, when stage to worker / endpoint assignment is done, it should leverage the TableGroup based placement info to setup the JOIN

siddharthteotia avatar Sep 16 '22 07:09 siddharthteotia

Hey @siddharthteotia,

Yes the changes are not complete. I am raising draft PRs so I can have a concrete discussion with you and Rong next week. Will keep you folks updated.

ankitsultana avatar Sep 16 '22 17:09 ankitsultana