pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Add Support for Cast Function on MV Columns

Open SabrinaZhaozyf opened this issue 2 years ago • 2 comments

Label: feature This PR adds support for Cast transform function for mv columns.

SabrinaZhaozyf avatar Aug 29 '22 22:08 SabrinaZhaozyf

Codecov Report

Merging #9296 (55b9ca1) into master (74fd91a) will decrease coverage by 2.36%. The diff coverage is 9.05%.

:exclamation: Current head 55b9ca1 differs from pull request most recent head 4e67bda. Consider uploading reports for the commit 4e67bda to get more accurate results

@@             Coverage Diff              @@
##             master    #9296      +/-   ##
============================================
- Coverage     28.44%   26.08%   -2.37%     
+ Complexity       53       44       -9     
============================================
  Files          1861     1861              
  Lines         99226    99473     +247     
  Branches      15123    15144      +21     
============================================
- Hits          28225    25946    -2279     
- Misses        68272    70924    +2652     
+ Partials       2729     2603     -126     
Flag Coverage Δ
integration1 26.08% <9.05%> (-0.06%) :arrow_down:
integration2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/pinot/broker/routing/BrokerRoutingManager.java 85.31% <ø> (-0.57%) :arrow_down:
...aggregation/function/AggregationFunctionUtils.java 70.00% <ø> (+0.76%) :arrow_up:
.../pinot/plugin/inputformat/csv/CSVRecordReader.java 0.00% <0.00%> (ø)
.../plugin/inputformat/csv/CSVRecordReaderConfig.java 0.00% <0.00%> (ø)
...lugin/inputformat/parquet/ParquetRecordReader.java 0.00% <0.00%> (ø)
...inputformat/parquet/ParquetRecordReaderConfig.java 0.00% <0.00%> (ø)
...pinot/plugin/inputformat/parquet/ParquetUtils.java 0.00% <0.00%> (ø)
.../java/org/apache/pinot/query/QueryEnvironment.java 0.00% <0.00%> (ø)
...a/org/apache/pinot/query/planner/PlannerUtils.java 0.00% <0.00%> (ø)
...not/query/planner/logical/RelToStageConverter.java 0.00% <ø> (ø)
... and 223 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 30 '22 17:08 codecov-commenter

Yet to review the main logic. Thanks for addressing the main concern of INTMV v/s INT

siddharthteotia avatar Aug 30 '22 20:08 siddharthteotia