pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Latest docker image doesn't include arm64

Open ntantri opened this issue 3 years ago • 6 comments

Hi,

While trying to build the Trino project with some test containers for pinot, we could see that it fails with M1 Mac, because the arm64 images for the specific image don't seem to be available in https://hub.docker.com/r/apachepinot/pinot/tags

In case, we use the image name as "apachepinot/pinot:0.10.0"; for test containers, it can't seem to get the arm64-specific tag. I had to fix this for M1 using "apachepinot/pinot:release-0.9.2-arm64-jdk11";

Isn't it possible to push tag images per OS/Arch?

ntantri avatar Aug 02 '22 14:08 ntantri

cc @xiangfu0 @elonazoulay

Jackie-Jiang avatar Aug 02 '22 18:08 Jackie-Jiang

We used to have the pipeline: https://github.com/apachepinot/pinot-fork/commit/2fe895373d8a9404a0d6bad2abef7b7e98e6d35f

But the docker build for arm64 really takes too long on amd machines, all existing CI from GitHub action failed due to timeout.

xiangfu0 avatar Aug 11 '22 17:08 xiangfu0

Hi @xiangfu0 ,

Thanks for the comment.

I am just shooting in the dark because I am unsure how much time it takes.

I saw the GitHub action has runs-on: ubuntu-latest but did you try this job run distro to choose archarm_latest (https://github.com/uraimo/run-on-arch-action)?

ntantri avatar Aug 11 '22 20:08 ntantri

Not yet.

The original goal is to create a multi-arch docker image with the same tag. So building an arm image on amd machine takes about 4 hours.

I think your suggestion makes more sense now, I can try to add a different task to just build arm image and push a different tag..

xiangfu0 avatar Aug 11 '22 21:08 xiangfu0

Oh, ok. Thanks. Let me know how it goes. If you are held up with other tasks, I am happy to help with this.

ntantri avatar Aug 12 '22 06:08 ntantri

I've added a nightly build image for arm64: https://github.com/apachepinot/pinot-fork/actions/workflows/nightly-build-pinot-arm64-platform-docker-image.yml

It takes about 5 hours to build.

The next try is to make a multi-arch build.

xiangfu0 avatar Aug 19 '22 09:08 xiangfu0