pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Improve error handling in MSE

Open gortiz opened this issue 1 month ago • 1 comments

Improve error handling in MSE:

  • Receivers will log the server that created the block (previously this was only logged in the broker)
  • Sending mailboxes won't log errors when the mailbox returns ALREADY_TERMINATED

gortiz avatar Dec 02 '25 16:12 gortiz

Codecov Report

:x: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.23%. Comparing base (d47ea27) to head (66a1b4f).

Files with missing lines Patch % Lines
...ache/pinot/query/runtime/blocks/ErrorMseBlock.java 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17306      +/-   ##
============================================
+ Coverage     63.22%   63.23%   +0.01%     
+ Complexity     1475     1474       -1     
============================================
  Files          3147     3147              
  Lines        187575   187586      +11     
  Branches      28712    28715       +3     
============================================
+ Hits         118590   118618      +28     
+ Misses        59794    59775      -19     
- Partials       9191     9193       +2     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.19% <87.50%> (+<0.01%) :arrow_up:
java-21 63.20% <87.50%> (+0.02%) :arrow_up:
temurin 63.23% <87.50%> (+0.01%) :arrow_up:
unittests 63.23% <87.50%> (+0.01%) :arrow_up:
unittests1 55.65% <87.50%> (+0.01%) :arrow_up:
unittests2 33.87% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 02 '25 17:12 codecov-commenter