pinot icon indicating copy to clipboard operation
pinot copied to clipboard

[Timeseries-storage] table config validation for DeltaDelta compressionCodec

Open deemoliu opened this issue 3 months ago • 1 comments

The PR has to be tagged with at least one of the following labels (*): feature

DeltaDelta compressioncodec can only be used in the long and int data type and single value column. This diff added a validation to reject the Delta Delta compression on other columns.

Link to the design doc: https://docs.google.com/document/d/1d3qqcAQea5i74ryFD-ShvLi4OWDociXILw8CoIHqORQ/edit?tab=t.0#heading=h.m7d2j6c4lhus

deemoliu avatar Nov 20 '25 22:11 deemoliu

Codecov Report

:x: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.24%. Comparing base (687770e) to head (5f8e53a).

Files with missing lines Patch % Lines
...he/pinot/segment/local/utils/TableConfigUtils.java 81.81% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17252      +/-   ##
============================================
+ Coverage     63.22%   63.24%   +0.02%     
+ Complexity     1433     1432       -1     
============================================
  Files          3128     3128              
  Lines        185689   185700      +11     
  Branches      28380    28382       +2     
============================================
+ Hits         117399   117447      +48     
+ Misses        59228    59185      -43     
- Partials       9062     9068       +6     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.20% <81.81%> (+<0.01%) :arrow_up:
java-21 63.18% <81.81%> (+0.01%) :arrow_up:
temurin 63.24% <81.81%> (+0.02%) :arrow_up:
unittests 63.24% <81.81%> (+0.02%) :arrow_up:
unittests1 55.63% <18.18%> (+0.03%) :arrow_up:
unittests2 33.89% <81.81%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 20 '25 23:11 codecov-commenter