apache
The Pinot UI should distinguish between a server being up and being healthy #16775
The frontend logic in PinotMethodUtils.ts has been enhanced with:
-
Health check functionality (lines 147-158):
checkInstanceHealthfunction that pings the/healthendpoint -
Enhanced status determination (lines 165-201): The
getInstanceDatafunction now includes logic to determine status based on:-
shutdownInProgressflag -
enabledstate -
queriesDisabledstate - Health endpoint response
- Live instance status
-
The status priority is correctly implemented:
- Dead (not alive)
- Shutting Down (alive + shutdownInProgress)
- Disabled (alive + not enabled)
- Queries Disabled (alive + queriesDisabled)
- Unhealthy (alive but health check fails)
- Healthy (alive + health check passes)
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.16%. Comparing base (7d38ce4) to head (9ed3f4a).
:warning: Report is 44 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #17248 +/- ##
============================================
- Coverage 63.18% 63.16% -0.03%
- Complexity 1428 1432 +4
============================================
Files 3117 3124 +7
Lines 184447 185376 +929
Branches 28289 28335 +46
============================================
+ Hits 116541 117085 +544
- Misses 58911 59246 +335
- Partials 8995 9045 +50
| Flag | Coverage Δ | |
|---|---|---|
| custom-integration1 | 100.00% <ø> (ø) |
|
| integration | 100.00% <ø> (ø) |
|
| integration1 | 100.00% <ø> (ø) |
|
| integration2 | 0.00% <ø> (ø) |
|
| java-11 | 63.13% <100.00%> (-0.04%) |
:arrow_down: |
| java-21 | 63.12% <100.00%> (+7.07%) |
:arrow_up: |
| temurin | 63.16% <100.00%> (-0.03%) |
:arrow_down: |
| unittests | 63.15% <100.00%> (-0.03%) |
:arrow_down: |
| unittests1 | 55.74% <ø> (-0.37%) |
:arrow_down: |
| unittests2 | 33.77% <100.00%> (+0.13%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
