pinot icon indicating copy to clipboard operation
pinot copied to clipboard

[Enhance] Optimize user login

Open hongkunxu opened this issue 1 month ago • 1 comments

  1. Fixed the login logic. Previously, the UI login only allowed users who had permissions for all tables, which was not reasonable, because the table list is empty during UI login.
  2. Deny regular users access to the ZooKeeper browser.

hongkunxu avatar Nov 20 '25 07:11 hongkunxu

Codecov Report

:x: Patch coverage is 2.50000% with 39 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.29%. Comparing base (95d43c0) to head (67ce743). :warning: Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...broker/broker/ZkBasicAuthAccessControlFactory.java 0.00% 19 Missing :warning:
...er/api/access/ZkBasicAuthAccessControlFactory.java 0.00% 16 Missing :warning:
...ler/api/resources/PinotControllerAuthResource.java 0.00% 2 Missing :warning:
...ller/api/access/BasicAuthAccessControlFactory.java 0.00% 1 Missing :warning:
...ache/pinot/core/auth/FineGrainedAccessControl.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17242      +/-   ##
============================================
+ Coverage     63.28%   63.29%   +0.01%     
  Complexity     1474     1474              
============================================
  Files          3154     3154              
  Lines        188007   187960      -47     
  Branches      28782    28779       -3     
============================================
- Hits         118977   118975       -2     
+ Misses        59807    59771      -36     
+ Partials       9223     9214       -9     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.25% <2.50%> (-0.01%) :arrow_down:
java-21 63.24% <2.50%> (+0.02%) :arrow_up:
temurin 63.29% <2.50%> (+0.01%) :arrow_up:
unittests 63.29% <2.50%> (+0.01%) :arrow_up:
unittests1 55.70% <0.00%> (+0.02%) :arrow_up:
unittests2 33.93% <2.50%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 20 '25 08:11 codecov-commenter