apache
do not add column name separator on download
This is a ui bugfix that closes #14302
columnNameSeparator was added in #8131 to allow displaying columns with the same name. But we don't need to carry that over when downloading the data.
I ran pinot locally and ensured downloaded data was identical except for #$%\d no longer being in the column name
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.74%. Comparing base (
59551e4) to head (ce0245c). Report is 1246 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #14303 +/- ##
============================================
+ Coverage 61.75% 63.74% +1.99%
- Complexity 207 1555 +1348
============================================
Files 2436 2659 +223
Lines 133233 145448 +12215
Branches 20636 22219 +1583
============================================
+ Hits 82274 92718 +10444
- Misses 44911 45886 +975
- Partials 6048 6844 +796
| Flag | Coverage Δ | |
|---|---|---|
| custom-integration1 | 100.00% <ø> (+99.99%) |
:arrow_up: |
| integration | 100.00% <ø> (+99.99%) |
:arrow_up: |
| integration1 | 100.00% <ø> (+99.99%) |
:arrow_up: |
| integration2 | 0.00% <ø> (ø) |
|
| java-11 | 63.72% <ø> (+2.01%) |
:arrow_up: |
| java-21 | 63.63% <ø> (+2.00%) |
:arrow_up: |
| skip-bytebuffers-false | 63.74% <ø> (+1.99%) |
:arrow_up: |
| skip-bytebuffers-true | 63.60% <ø> (+35.87%) |
:arrow_up: |
| temurin | 63.74% <ø> (+1.99%) |
:arrow_up: |
| unittests | 63.74% <ø> (+1.99%) |
:arrow_up: |
| unittests1 | 55.38% <ø> (+8.49%) |
:arrow_up: |
| unittests2 | 34.25% <ø> (+6.51%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
