pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Add configs to specify keepAlive and shutdownTimeout for GrpcQueryClient

Open mayankshriv opened this issue 1 year ago • 1 comments

Added configs to specify keepAlive and shutdownTimeout for GrpcQueryClient.

  • Added channelShutdownTimeoutSecond config for GrpcQueryClient with default of 10s.
  • Added configs for keep-alive:
    • channelKeepAliveEnabled to enable/disable the feature, default false.
    • channelKeepAliveTimeSeconds to configures the interval for sending keep-alive pings, default 300 seconds (5 minutes).
    • channelKeepAliveTimeoutSeconds configures the timeout for waiting for a ping acknowledgment, default 300 seconds (5 minutes).
    • channelKeepAliveWithoutCalls ensures pings are sent even when there are no active calls, keeping the connection alive during idle period, default true.

mayankshriv avatar Jul 04 '24 23:07 mayankshriv

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 62.12%. Comparing base (59551e4) to head (d3889a5). Report is 730 commits behind head on master.

Files Patch % Lines
...pache/pinot/common/utils/grpc/GrpcQueryClient.java 0.00% 12 Missing :warning:
...ava/org/apache/pinot/common/config/GrpcConfig.java 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13546      +/-   ##
============================================
+ Coverage     61.75%   62.12%   +0.37%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2558     +122     
  Lines        133233   140916    +7683     
  Branches      20636    21866    +1230     
============================================
+ Hits          82274    87543    +5269     
- Misses        44911    46741    +1830     
- Partials       6048     6632     +584     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration <0.01% <0.00%> (-0.01%) :arrow_down:
integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration2 0.00% <0.00%> (ø)
java-11 62.07% <0.00%> (+0.36%) :arrow_up:
java-21 61.98% <0.00%> (+0.36%) :arrow_up:
skip-bytebuffers-false 62.10% <0.00%> (+0.35%) :arrow_up:
skip-bytebuffers-true 61.96% <0.00%> (+34.23%) :arrow_up:
temurin 62.12% <0.00%> (+0.37%) :arrow_up:
unittests 62.11% <0.00%> (+0.37%) :arrow_up:
unittests1 46.65% <0.00%> (-0.24%) :arrow_down:
unittests2 27.69% <0.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 05 '24 00:07 codecov-commenter