pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Add pinot-core dependency back to JDBC client

Open KKcorps opened this issue 1 year ago • 3 comments

PR #11620 removed pinot-core dependency from the pinot-jdbc-client since it was not needed for Auth anymore

However, there are a lot of other deps such as sl4j which jdbc client needs from pinot-core that went missing after this PR

This is causing a lot of class not found issues when JDBC driver 1.1.0 shaded jar is used which don't happen when we use 1.0.0

KKcorps avatar Jun 13 '24 08:06 KKcorps

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.98%. Comparing base (59551e4) to head (22281bd). Report is 616 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13384      +/-   ##
============================================
+ Coverage     61.75%   61.98%   +0.22%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2550     +114     
  Lines        133233   140257    +7024     
  Branches      20636    21801    +1165     
============================================
+ Hits          82274    86934    +4660     
- Misses        44911    46721    +1810     
- Partials       6048     6602     +554     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) :arrow_down:
integration <0.01% <ø> (-0.01%) :arrow_down:
integration1 <0.01% <ø> (-0.01%) :arrow_down:
integration2 0.00% <ø> (ø)
java-11 61.94% <ø> (+0.23%) :arrow_up:
java-21 61.87% <ø> (+0.24%) :arrow_up:
skip-bytebuffers-false 61.96% <ø> (+0.22%) :arrow_up:
skip-bytebuffers-true 61.84% <ø> (+34.12%) :arrow_up:
temurin 61.98% <ø> (+0.22%) :arrow_up:
unittests 61.97% <ø> (+0.23%) :arrow_up:
unittests1 46.55% <ø> (-0.34%) :arrow_down:
unittests2 27.66% <ø> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 13 '24 08:06 codecov-commenter

pinot-core depends on four other(pinot-spi, pinot-segment-spi, pinot-segment-local, pinot-common). We have removed it because of the heavy client, as mentioned in this issue.

In my opinion, instead of adding a pinot-core back, we should add individual external dependencies if that solves the problem or do some refactoring to solve the problem.

abhioncbr avatar Jun 13 '24 14:06 abhioncbr

@abhioncbr yeah you are right, let me see what other dependencies can we pull

KKcorps avatar Jun 20 '24 04:06 KKcorps