pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Improve logging during filtering event consumption

Open tibrewalpratik17 opened this issue 2 years ago • 1 comments

label: observability

  • Small follow-up fix to #12594
  • Also adding logs to track offsets of filtered events. Publishing this log every 1 minute along with Consumed x events log. Added a separate log and did not club with consumed events for easy debuggability. Please suggest if there is a better way of tracking this.

tibrewalpratik17 avatar Mar 08 '24 07:03 tibrewalpratik17

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 62.08%. Comparing base (59551e4) to head (7d3579a). Report is 317 commits behind head on master.

Files Patch % Lines
...a/manager/realtime/RealtimeSegmentDataManager.java 16.66% 8 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12602      +/-   ##
============================================
+ Coverage     61.75%   62.08%   +0.33%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136479    +3246     
  Branches      20636    21124     +488     
============================================
+ Hits          82274    84732    +2458     
- Misses        44911    45465     +554     
- Partials       6048     6282     +234     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration <0.01% <0.00%> (-0.01%) :arrow_down:
integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration2 0.00% <0.00%> (ø)
java-11 <0.01% <0.00%> (-61.71%) :arrow_down:
java-21 62.08% <37.50%> (+0.45%) :arrow_up:
skip-bytebuffers-false 62.06% <37.50%> (+0.32%) :arrow_up:
skip-bytebuffers-true 62.03% <37.50%> (+34.31%) :arrow_up:
temurin 62.08% <37.50%> (+0.33%) :arrow_up:
unittests 62.08% <37.50%> (+0.33%) :arrow_up:
unittests1 46.50% <37.50%> (-0.39%) :arrow_down:
unittests2 28.01% <0.00%> (+0.28%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 08 '24 08:03 codecov-commenter