pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Interning for OnHeapByteDictionary

Open vvivekiyer opened this issue 1 year ago • 1 comments

  • Applies interning for OnHeapByteDictionary. Please refer to https://github.com/apache/pinot/pull/12223 for more details.
  • Addresses some pending review comments from https://github.com/apache/pinot/pull/12223

vvivekiyer avatar Jan 31 '24 01:01 vvivekiyer

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d501478) 61.67% compared to head (a9af3e2) 61.74%. Report is 43 commits behind head on master.

Files Patch % Lines
.../segment/index/dictionary/DictionaryIndexType.java 40.00% 4 Missing and 2 partials :warning:
...ain/java/org/apache/pinot/spi/utils/ByteArray.java 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12342      +/-   ##
============================================
+ Coverage     61.67%   61.74%   +0.06%     
  Complexity      207      207              
============================================
  Files          2422     2436      +14     
  Lines        132148   133138     +990     
  Branches      20385    20619     +234     
============================================
+ Hits          81502    82202     +700     
- Misses        44660    44896     +236     
- Partials       5986     6040      +54     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration <0.01% <0.00%> (-0.01%) :arrow_down:
integration1 <0.01% <0.00%> (-0.01%) :arrow_down:
integration2 0.00% <0.00%> (ø)
java-11 61.70% <80.95%> (+0.08%) :arrow_up:
java-21 61.62% <80.95%> (+0.06%) :arrow_up:
skip-bytebuffers-false 61.73% <80.95%> (+0.06%) :arrow_up:
skip-bytebuffers-true 61.60% <80.95%> (+0.06%) :arrow_up:
temurin 61.74% <80.95%> (+0.06%) :arrow_up:
unittests 61.73% <80.95%> (+0.06%) :arrow_up:
unittests1 46.88% <69.04%> (+0.04%) :arrow_up:
unittests2 27.72% <11.90%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 15 '24 23:02 codecov-commenter