pinot icon indicating copy to clipboard operation
pinot copied to clipboard

Group-by without ordering on aggregate

Open Jackie-Jiang opened this issue 2 years ago • 1 comments

When a group-by query does not have order-by on the aggregate column, we don't need to keep more groups than the LIMIT because the order-by value won't change. We can maintain a heap (PriorityQueue) of LIMIT values. On the group-key generation side, we should also keep only the relevant keys.

One common query is: SELECT COUNT(*) FROM myTable GROUP BY timeCol ORDER BY timeCol DESC LIMIT 10

Problems to solve:

  1. Group-by query with order-by on the key column: Currently we keep Math.max(5000, LIMIT * 5) groups, which is not necessary since only the top LIMIT groups are relevant

  2. Group-by query without order-by: Currently we keep random LIMIT groups per server, and there is no guarantee the same group is picked across different servers, which can lead to wrong result when there are more than LIMIT groups

Solution:

  1. To ensure the ordering is deterministic (we need this guarantee to ensure the groups returned from all servers are the same), we should append all non-ordering group keys implicitly. This is one exception: when we want to keep all groups on the server, we don't need this since all groups will be returned anyway.
  2. Optimize the execution when all the ordering keys are group key

Jackie-Jiang avatar Sep 28 '23 20:09 Jackie-Jiang

@Jackie-Jiang If no one have picked this up - I can pick it up

anandheritage avatar Sep 25 '24 13:09 anandheritage

https://github.com/apache/pinot/pull/15844

@Jackie-Jiang

anandheritage avatar May 20 '25 09:05 anandheritage