phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-5872 Close Internal Phoenix Connections that were running dur…

Open dbwong opened this issue 5 years ago • 6 comments

…ing cancel

dbwong avatar May 04 '20 21:05 dbwong

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 0s Docker mode activated.
-1 :x: patch 0m 3s https://github.com/apache/phoenix/pull/775 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/phoenix/pull/775
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/1/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Sep 28 '20 17:09 stoty

@dbwong - looks like this was committed to 4.x but not master, but now needs a rebase to be committed. When you get a minute, could you please take a look?

gjacoby126 avatar Nov 18 '20 20:11 gjacoby126

Updated @ChinmaySKulkarni @gjacoby126 for master changes please review i'll update the patch on the jira as well. @sakshamgangwar fyi for master path for your follow up jira as well.

dbwong avatar Nov 24 '20 18:11 dbwong

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 5m 16s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 12m 33s master passed
+1 :green_heart: compile 0m 58s master passed
+1 :green_heart: checkstyle 2m 21s master passed
+1 :green_heart: javadoc 0m 47s master passed
+0 :ok: spotbugs 2m 52s phoenix-core in master has 966 extant spotbugs warnings.
-0 :warning: patch 2m 59s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
-1 :x: mvninstall 1m 1s root in the patch failed.
-1 :x: compile 0m 50s phoenix-core in the patch failed.
-1 :x: javac 0m 50s phoenix-core in the patch failed.
-1 :x: checkstyle 2m 26s phoenix-core: The patch generated 64 new + 4559 unchanged - 15 fixed = 4623 total (was 4574)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 41s the patch passed
-1 :x: spotbugs 0m 49s phoenix-core in the patch failed.
_ Other Tests _
-1 :x: unit 0m 46s phoenix-core in the patch failed.
+1 :green_heart: asflicense 0m 10s The patch does not generate ASF License warnings.
32m 19s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix/pull/775
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux ebb1d6da4dc2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / f1f92aa
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/testReport/
Max. process+thread count 94 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Nov 24 '20 19:11 stoty

@dbwong , apologies, but could you please rebase one more time?

gjacoby126 avatar Dec 01 '20 23:12 gjacoby126

Ping @dbwong can you please rebase so we can get this in master as well? There is another Jira (PHOENIX-6256) which depends on this along with @sakshamgangwar's Jira. FYI @yanxinyi

ChinmaySKulkarni avatar Dec 10 '20 23:12 ChinmaySKulkarni

Already merged.

stoty avatar Aug 01 '23 15:08 stoty