phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-5756 Remove Thread.sleep usage from QueryLoggerIT

Open mihir6692 opened this issue 5 years ago • 3 comments

mihir6692 avatar Mar 04 '20 18:03 mihir6692

Thanks @mihir6692 for the pull request, do we know what change we did in async logging that we don't require sleep now?

ankitsinghal avatar Mar 04 '20 19:03 ankitsinghal

Yes, i would take a deeper look at it as this test fails in PreCommit but passes in local.

mihir6692 avatar Mar 05 '20 08:03 mihir6692

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 15m 29s master passed
+0 hbaserecompile 22m 13s HBase recompiled.
+1 :green_heart: compile 1m 4s master passed
+1 :green_heart: checkstyle 0m 32s master passed
+1 :green_heart: javadoc 0m 52s master passed
+0 :ok: spotbugs 3m 14s phoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 8m 51s the patch passed
+0 hbaserecompile 18m 40s HBase recompiled.
+1 :green_heart: compile 1m 11s the patch passed
+1 :green_heart: javac 1m 11s the patch passed
+1 :green_heart: checkstyle 0m 38s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 54s the patch passed
+1 :green_heart: spotbugs 3m 41s the patch passed
_ Other Tests _
-1 :x: unit 105m 49s phoenix-core in the patch failed.
+1 :green_heart: asflicense 0m 43s The patch does not generate ASF License warnings.
159m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-722/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix/pull/722
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux f99f09dde08c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 6ed3caf
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-722/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-722/1/testReport/
Max. process+thread count 13258 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-722/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Feb 16 '21 05:02 stoty