phoenix
phoenix copied to clipboard
PHOENIX-5369: BasePermissionsIT.testReadPermsOnTableIndexAndView test uses an incorrect user for permission based operations
BasePermissionsIT.testReadPermsOnTableIndexAndView test uses an incorrect user for permission based operations
Line 954 uses the same regularUser1 to GRANT permission to regularUser2. Shouldn't they be consistent? (And shouldn't a User who has the right to grant a permission also have the right to revoke it?)
Line 954 uses the same regularUser1 to GRANT permission to regularUser2. Shouldn't they be consistent? (And shouldn't a User who has the right to grant a permission also have the right to revoke it?)
Yeah, make sense. It might be a new bug? I'll check to see if granting permission is also happening as an RPC call and that's why its working.
:broken_heart: -1 overall
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
+0 :ok: | reexec | 2m 21s | Docker mode activated. |
_ Prechecks _ | |||
+1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
+1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
-1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
_ master Compile Tests _ | |||
+1 :green_heart: | mvninstall | 19m 33s | master passed |
+0 | hbaserecompile | 28m 38s | HBase recompiled. |
+1 :green_heart: | compile | 1m 21s | master passed |
+1 :green_heart: | checkstyle | 0m 47s | master passed |
+1 :green_heart: | javadoc | 1m 7s | master passed |
+0 :ok: | spotbugs | 4m 13s | phoenix-core in master has 959 extant spotbugs warnings. |
_ Patch Compile Tests _ | |||
+1 :green_heart: | mvninstall | 13m 0s | the patch passed |
+0 | hbaserecompile | 26m 16s | HBase recompiled. |
+1 :green_heart: | compile | 1m 21s | the patch passed |
+1 :green_heart: | javac | 1m 21s | the patch passed |
+1 :green_heart: | checkstyle | 0m 42s | the patch passed |
+1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 :green_heart: | javadoc | 1m 12s | the patch passed |
+1 :green_heart: | spotbugs | 4m 8s | the patch passed |
_ Other Tests _ | |||
-1 :x: | unit | 108m 34s | phoenix-core in the patch failed. |
+1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
180m 18s |
Reason | Tests |
---|---|
Failed junit tests | phoenix.end2end.PermissionNSDisabledIT |
phoenix.end2end.PermissionsCacheIT |
Subsystem | Report/Notes |
---|---|
Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-524/1/artifact/yetus-general-check/output/Dockerfile |
GITHUB PR | https://github.com/apache/phoenix/pull/524 |
JIRA Issue | PHOENIX-5369 |
Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
uname | Linux 3064b964bb76 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | dev/phoenix-personality.sh |
git revision | master / 6ed3caf |
Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-524/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-524/1/testReport/ |
Max. process+thread count | 10767 (vs. ulimit of 30000) |
modules | C: phoenix-core U: phoenix-core |
Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-524/1/console |
versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.