phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-5167: fix some LGTM alerts

Open malcolmtaylor opened this issue 6 years ago • 3 comments
trafficstars

Fix some of the alerts:

  • Type mismatch on container access in MetaDataClient and TupleProjectionCompiler
  • Type mismatch on container modification in ServerCacheClient
  • Equals does not inspect argument type in Column
  • Equals on incomparable types in SubselectRewriter, MultiHfileOutputFormat and GuidePostsInfo
  • Missing format argument in BaseEventSerializer
  • Reference equality on boxed types in ColumnInfo (twice), ArrayFillFunction and PArrayDataType

malcolmtaylor avatar Feb 27 '19 14:02 malcolmtaylor

@swaroopak thanks for reviewing. I have rebased to fix the delete/modify conflict.

malcolmtaylor avatar Apr 07 '19 05:04 malcolmtaylor

@karanmehta93 @abhishek-chouhan Could you please commit this? Thanks.

swaroopak avatar Apr 10 '19 20:04 swaroopak

Rebased

malcolmtaylor avatar Aug 20 '19 08:08 malcolmtaylor