phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-4902 Use only compressed portion of hash cache memory buffer

Open ortutay opened this issue 7 years ago • 4 comments

See ticket https://issues.apache.org/jira/browse/PHOENIX-4902 for description of issue. Current code loses Snappy compression benefits, this change makes sure only the compressed portion is sent in the RPC message.

ortutay avatar Sep 16 '18 04:09 ortutay

Ping, please let me know if there are any issues with this PR

ortutay avatar Oct 08 '18 18:10 ortutay

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 5m 52s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 17m 1s master passed
+0 hbaserecompile 24m 12s HBase recompiled.
+1 :green_heart: compile 1m 15s master passed
+1 :green_heart: checkstyle 0m 34s master passed
+1 :green_heart: javadoc 0m 52s master passed
+0 :ok: spotbugs 3m 43s phoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 10m 13s the patch passed
+0 hbaserecompile 21m 18s HBase recompiled.
+1 :green_heart: compile 1m 15s the patch passed
+1 :green_heart: javac 1m 15s the patch passed
+1 :green_heart: checkstyle 0m 38s phoenix-core: The patch generated 0 new + 101 unchanged - 2 fixed = 101 total (was 103)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 58s the patch passed
+1 :green_heart: spotbugs 3m 56s the patch passed
_ Other Tests _
-1 :x: unit 118m 0s phoenix-core in the patch failed.
+1 :green_heart: asflicense 0m 38s The patch does not generate ASF License warnings.
182m 29s
Reason Tests
Failed junit tests phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
phoenix.end2end.UpsertSelectIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix/pull/349
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux 4c1eb8b054b3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 6ed3caf
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count 9636 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Feb 16 '21 06:02 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 5m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 1s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 27m 11s master passed
+0 hbaserecompile 35m 48s HBase recompiled.
+1 :green_heart: compile 1m 20s master passed
+1 :green_heart: checkstyle 1m 9s master passed
+1 :green_heart: javadoc 1m 0s master passed
+0 :ok: spotbugs 3m 54s phoenix-core in master has 970 extant spotbugs warnings.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 18m 49s the patch passed
+0 hbaserecompile 31m 28s HBase recompiled.
+1 :green_heart: compile 1m 13s the patch passed
+1 :green_heart: javac 1m 13s the patch passed
+1 :green_heart: checkstyle 0m 59s phoenix-core: The patch generated 0 new + 44 unchanged - 2 fixed = 44 total (was 46)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 56s the patch passed
+1 :green_heart: spotbugs 3m 35s the patch passed
_ Other Tests _
-1 :x: unit 114m 4s phoenix-core in the patch failed.
+1 :green_heart: asflicense 0m 49s The patch does not generate ASF License warnings.
201m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix/pull/349
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux 65a28e9d6a07 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / a4f0304
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count 14741 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jul 30 '21 06:07 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 7m 57s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 27m 29s master passed
+0 hbaserecompile 35m 50s HBase recompiled.
+1 :green_heart: compile 1m 12s master passed
+1 :green_heart: checkstyle 1m 6s master passed
+1 :green_heart: javadoc 1m 0s master passed
+0 :ok: spotbugs 3m 37s phoenix-core in master has 972 extant spotbugs warnings.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 21m 58s the patch passed
+0 hbaserecompile 33m 17s HBase recompiled.
+1 :green_heart: compile 1m 14s the patch passed
+1 :green_heart: javac 1m 14s the patch passed
+1 :green_heart: checkstyle 1m 4s phoenix-core: The patch generated 0 new + 44 unchanged - 2 fixed = 44 total (was 46)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 57s the patch passed
+1 :green_heart: spotbugs 3m 48s the patch passed
_ Other Tests _
+1 :green_heart: unit 125m 23s phoenix-core in the patch passed.
+1 :green_heart: asflicense 0m 17s The patch does not generate ASF License warnings.
214m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix/pull/349
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux e8c706b95663 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 67cef07
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count 11386 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Sep 07 '21 18:09 stoty