apache
PHOENIX-7417 Remove commons-collections dependency
- Remove imports and replace with equivalent code
- Add RestrictImports rule to restrict further usage of it in codebase
We have same in query server also. Do we use same ticket for both PRs? Or raise new Jira for queryserver PR?
Saw an import issue in code change. Went ahead and raised https://github.com/apache/phoenix/pull/1995/ as fixing manually is too cumbersome
There is minimal functionality that we use here.
Wouldn't it be better to just get rid of this dependency ?
Wouldn't it be better to just get rid of this dependency ?
Sure let me see if I can remove the usage of commons-collections altogether
Wouldn't it be better to just get rid of this dependency ?
Sure let me see if I can remove the usage of commons-collections altogether
Done!
please fix the checkstyle errors before commit (unless they are pre-existing)
please fix the checkstyle errors before commit (unless they are pre-existing)
/phoenix-core-client/src/main/java/org/apache/phoenix/util/QueryBuilder.java:150: is new let me fix this
Thank you @stoty I plan to fix this for other phoenix projects. PQS also depends on commons-collections. Raised PHOENIX-7430.