phoenix PHOENIX-6851 Add spotless to format code

Jan 02 '23 10:01 mnpoonia

Yetus checks seems to fail for a comment which is a url. I am hoping that is fine. @virajjasani

Jan 03 '23 04:01 mnpoonia

HBase also did something like one time format of the entire codebase. Ever since then, every PR merge follows spotless way of format to maintain same format. Do we want to start using spotless after this commit (without touching current codebase)?

FYI @stoty you might also have some thoughts.

Jan 04 '23 03:01 virajjasani

I am planning to create a subtask to do a one time formatting for entire codebase. @virajjasani

Jan 04 '23 03:01 mnpoonia

If we do this, then IMO the code cleanup and the check should be committed together.

One hand this would be a major PITA, for backports, etc. On the other hand the current code looks horrible.

I don't have a strong opinion either way. I think that this should be discussed on the dev@ list, as this is a very intrusive change.

Jan 16 '23 15:01 stoty