phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Published 20 hours ago • verified publisher icon apache

Phoenix 6728

Open thrylokya opened this issue 3 years ago • 1 comments

Changed JoinCompiler.java, QueryOptimizer.java. The changes include null checks to avoid the NPE during the exists operation. Added test in QueryOptimizerTest.java

cc @stoty : Could you review my changes and let me know.

thrylokya avatar Sep 04 '22 23:09 thrylokya

I haven't looked at the actual code changes yet, but

  1. Please change the commit message to conform to the conventions (see previous messages)
  2. Use rebase instead of merge to manage changes in master
  3. Undo the code reformats on lines that you haven't changed, they make finding and reviewing the actual changes difficult (ignore the Yetus errors for those)
  4. Remove unrelated first commit from PR (or fix the commit message if it is related).
  5. There are a lot of Yetus errors, starting with compilation. Please fix those.

You'll have to force-push the new version of the PR, that's ok.

stoty avatar Sep 05 '22 15:09 stoty