phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Published 20 hours ago • verified publisher icon apache

Utility classes should not have public constructors

Open zeeshanasghar opened this issue 9 years ago • 4 comments

This pull request is focused on resolving occurrences of rule: squid:S1118 - Utility classes should not have public constructors.

You can find more information about the issue here: http://dev.eclipse.org/sonar/rules/show/squid:S1118

Please let me know if you have any questions.

Zeeshan

zeeshanasghar avatar Jan 24 '16 04:01 zeeshanasghar

Thanks for the PR, @zeeshanasghar. Please file a JIRA and prepend the JIRA number (i.e. PHOENIX-####) to your git commit message.

Would you mind reviewing, @samarthjain ?

JamesRTaylor avatar Jan 24 '16 04:01 JamesRTaylor

Thaks @samarthjain.

Jira number is: PHOENIX-2627

zeeshanasghar avatar Jan 25 '16 01:01 zeeshanasghar

@zeeshanasghar - patch looks fine to me. There are formatting issues in almost all the files though. See my comments on org/apache/phoenix/cache/JodaTimezoneCache.java. Also make sure to run mvn verify to ensure the changes didn't cause any regressions.

samarthjain avatar Jan 25 '16 18:01 samarthjain

@zeeshanasghar - please amend your commit message to "PHOENIX-2627 Utility classes should not have public constructors" so that conversations on the pull request are reflected in the JIRA.

JamesRTaylor avatar Jan 25 '16 19:01 JamesRTaylor