phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE…

Open gjacoby126 opened this issue 3 years ago • 3 comments

… compilation phase leads to poor performance

gjacoby126 avatar Jul 21 '22 19:07 gjacoby126

This is a rebase of #1467 since merging #1465 caused GitHub to incorrectly think there was a merge conflict there. (This is still @jpisaac 's code, I'm just doing it since he's out of office.) @dbwong and @tkhurana , you know the query parsing code better than me, so could you please take a look?

gjacoby126 avatar Jul 21 '22 19:07 gjacoby126

This PR has caused InListIT to crash twice in the test environment, and InListIT is a test that it modifies. More investigation is needed before it can be merged. @jpisaac , @dbwong , @tkhurana , fyi.

gjacoby126 avatar Jul 22 '22 22:07 gjacoby126

@jpisaac - the new test in InListIT was causing OOMs during the iteration where it ran with 50,000 ORs (both in CI and locally). I tweaked it so it runs with at most 5000 ORs, and now it passes for me locally. If 50,000 ORs needs to be supported, either the test heap size needs to be bigger, or we need further optimization.

gjacoby126 avatar Aug 02 '22 22:08 gjacoby126

I'll let @jpisaac re-base his original PR now that he's back and close this one.

gjacoby126 avatar Sep 07 '22 19:09 gjacoby126