phoenix
phoenix copied to clipboard
Published
20 hours ago •
apache
apache
PHOENIX-6523: Support for HRpc connection protocol through JDBC URL
HBase now supports a zookeeper-less connection strategy using a Master Registry implementation. For this to work through Phoenix, we need to set a list host:ports of the HMaster quorum
<property>
<name>hbase.masters</name>
<value>master1:16000,master2:16001,master3:16000</value>
</property>
To support opting into this from a Phoenix connection URL, we can introduce a "connector type" as follows:
jdbc:phoenix+zk:hostname1,2,3...:<properties>
jdbc:phoenix+hrpc:hostname1,2,3...:<properties>
Above are examples of opting into hrpc/zk registry implementations of HBase.
If no connector is specified, the Phoenix driver will default to a Zookeeper-based connection as it's always been doing prior to this. If an invalid connector type is specified, we throw a MalformedUrlException, similarly if there's a + char but the connector type is empty.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 22s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 21m 37s | master passed |
| +0 | hbaserecompile | 28m 38s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 2s | master passed |
| +1 :green_heart: | checkstyle | 1m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 52s | master passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in master has 973 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| -1 :x: | mvninstall | 0m 31s | root in the patch failed. |
| +0 | hbaserecompile | 9m 58s | HBase recompiled. |
| -1 :x: | compile | 0m 20s | phoenix-core in the patch failed. |
| -1 :x: | javac | 0m 20s | phoenix-core in the patch failed. |
| -1 :x: | checkstyle | 1m 16s | phoenix-core: The patch generated 24 new + 737 unchanged - 15 fixed = 761 total (was 752) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed |
| -1 :x: | spotbugs | 0m 19s | phoenix-core in the patch failed. |
| _ Other Tests _ | |||
| -1 :x: | unit | 0m 19s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| 52m 34s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 823e64d1ba6c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / c4d297d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/testReport/ |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 24m 13s | master passed |
| +0 | hbaserecompile | 31m 12s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 13s | master passed |
| +1 :green_heart: | javadoc | 0m 51s | master passed |
| +0 :ok: | spotbugs | 3m 26s | phoenix-core in master has 973 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 16m 53s | the patch passed |
| +0 | hbaserecompile | 27m 22s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | the patch passed |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 33 new + 727 unchanged - 25 fixed = 760 total (was 752) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 51s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 38s | the patch passed |
| _ Other Tests _ | |||
| -1 :x: | unit | 117m 50s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 34s | The patch does not generate ASF License warnings. |
| 190m 58s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 5da2aa6dfc67 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / c4d297d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/testReport/ |
| Max. process+thread count | 11607 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 21m 57s | master passed |
| +0 | hbaserecompile | 28m 49s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 2s | master passed |
| +1 :green_heart: | checkstyle | 1m 14s | master passed |
| +1 :green_heart: | javadoc | 0m 51s | master passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in master has 973 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 13m 30s | the patch passed |
| +0 | hbaserecompile | 25m 52s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 3s | the patch passed |
| +1 :green_heart: | javac | 1m 3s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 20 new + 735 unchanged - 17 fixed = 755 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 2 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 15s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 119m 13s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| 186m 0s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux edf46d24c8ec 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / c4d297d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/artifact/yetus-general-check/output/whitespace-tabs.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/testReport/ |
| Max. process+thread count | 7332 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 45s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 24m 27s | master passed |
| +0 | hbaserecompile | 36m 48s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 7s | master passed |
| +1 :green_heart: | checkstyle | 1m 11s | master passed |
| +1 :green_heart: | javadoc | 0m 54s | master passed |
| +0 :ok: | spotbugs | 3m 30s | phoenix-core in master has 973 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 16m 41s | the patch passed |
| +0 | hbaserecompile | 33m 6s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 3s | the patch passed |
| +1 :green_heart: | javac | 1m 3s | the patch passed |
| -1 :x: | checkstyle | 1m 13s | phoenix-core: The patch generated 29 new + 725 unchanged - 27 fixed = 754 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 2 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 31s | the patch passed |
| _ Other Tests _ | |||
| -1 :x: | unit | 116m 43s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| 206m 49s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 119635c75cbf 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / c4d297d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/whitespace-tabs.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/testReport/ |
| Max. process+thread count | 12703 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/5/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
jdbc:phoenix+zk:hostname1,2,3...:<properties>
jdbc:phoenix+hrpc:hostname1,2,3...:<properties>
What is "hrpc" supposed to stand for in this case? I would think "masters" or "registry" might be more clear?
I think the problem here is that @bharathv built the "default" implementation to be pluggable. While this is nice, do we have any expectations to support any possible mechanism? It would be helpful (for me, a reviewer) to understand what is in scope and what's out of scope. I'm assuming you don't want to try to support any registry, but it might be a good idea to keep that in mind so as to not code ourselves into a corner.
to understand what is in scope and what's out of scope
The scope right now is to support HBase registry if specified or else always default to ZK. I think the most important thing here is to ensure there's no regression to existing connections. This HRpc thing should be treated as an opt-in, else we should preserve the same behaviour as before.
I'm assuming you don't want to try to support any registry, but it might be a good idea to keep that in mind so as to not code ourselves into a corner.
I think using some OOP to clean the classes up as you suggested is a good foundation to set for other registries down the road
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 5m 38s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 24m 19s | master passed |
| +0 | hbaserecompile | 31m 26s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 8s | master passed |
| +1 :green_heart: | checkstyle | 1m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 52s | master passed |
| +0 :ok: | spotbugs | 3m 20s | phoenix-core in master has 972 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 16m 36s | the patch passed |
| +0 | hbaserecompile | 27m 14s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 7s | the patch passed |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| -1 :x: | checkstyle | 1m 20s | phoenix-core: The patch generated 36 new + 735 unchanged - 17 fixed = 771 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 2 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 57s | the patch passed |
| +1 :green_heart: | spotbugs | 4m 11s | the patch passed |
| _ Other Tests _ | |||
| -1 :x: | unit | 122m 8s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 34s | The patch generated 5 ASF License warnings. |
| 200m 52s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux edb51fb2019d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / bfc4621 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/whitespace-tabs.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 11315 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/6/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 24m 13s | master passed |
| +0 | hbaserecompile | 31m 58s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 16s | master passed |
| +1 :green_heart: | javadoc | 0m 52s | master passed |
| +0 :ok: | spotbugs | 3m 20s | phoenix-core in master has 972 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 16m 46s | the patch passed |
| +0 | hbaserecompile | 27m 37s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 35 new + 735 unchanged - 17 fixed = 770 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 2 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 53s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 33s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 118m 2s | phoenix-core in the patch passed. |
| -1 :x: | asflicense | 0m 14s | The patch generated 5 ASF License warnings. |
| 190m 7s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux ba856428ad27 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / bfc4621 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/whitespace-tabs.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 10727 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/7/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
@stoty the links to checkstyle/whitespaces are missing
Also @joshelser I split and moved the parsing logic into classes
@ramatronics the build artifacts are cleaned up aggressively in a fews days, as the jenkins hosts have little storage. You need to trigger a rebuild (or just run those checks locally).
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 6m 54s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 30m 3s | master passed |
| +0 | hbaserecompile | 39m 23s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 54s | master passed |
| +0 :ok: | spotbugs | 3m 22s | phoenix-core in master has 972 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 16m 49s | the patch passed |
| +0 | hbaserecompile | 29m 49s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 7s | the patch passed |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| -1 :x: | checkstyle | 1m 16s | phoenix-core: The patch generated 35 new + 735 unchanged - 17 fixed = 770 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 2 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 51s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 32s | the patch passed |
| _ Other Tests _ | |||
| -1 :x: | unit | 116m 15s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 34s | The patch generated 5 ASF License warnings. |
| 205m 54s |
| Reason | Tests |
|---|---|
| Failed junit tests | phoenix.end2end.UpsertSelectIT |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 43818037d335 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9dfb423 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/whitespace-tabs.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 11682 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/8/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 5m 56s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 24m 2s | master passed |
| +0 | hbaserecompile | 31m 7s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 14s | master passed |
| +1 :green_heart: | javadoc | 0m 52s | master passed |
| +0 :ok: | spotbugs | 3m 23s | phoenix-core in master has 972 extant spotbugs warnings. |
| -0 :warning: | patch | 3m 32s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 16m 44s | the patch passed |
| +0 | hbaserecompile | 27m 5s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 36 new + 735 unchanged - 17 fixed = 771 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 4 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 51s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 30s | the patch passed |
| _ Other Tests _ | |||
| -1 :x: | unit | 161m 56s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 14s | The patch generated 5 ASF License warnings. |
| 237m 53s |
| Reason | Tests |
|---|---|
| Failed junit tests | phoenix.mapreduce.util.PhoenixConfigurationUtilTest |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 8979c3c1e2f9 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 19b2260 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/whitespace-tabs.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 432 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/9/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
Looking at the code, I'd expect PhoenixEmbeddedDriver.ConnectionInfo.normalize() to fail for Hrpc connections. Could you add an Integration Test to check that the Hrpc connections work (i.e. starting a minicluster and connecting to it with HRPC) ?
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 5m 53s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 21m 22s | master passed |
| +0 | hbaserecompile | 28m 3s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | master passed |
| +1 :green_heart: | checkstyle | 1m 15s | master passed |
| +1 :green_heart: | javadoc | 0m 51s | master passed |
| +0 :ok: | spotbugs | 3m 6s | phoenix-core in master has 972 extant spotbugs warnings. |
| -0 :warning: | patch | 3m 15s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 13m 25s | the patch passed |
| +0 | hbaserecompile | 23m 12s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 5s | the patch passed |
| +1 :green_heart: | javac | 1m 5s | the patch passed |
| -1 :x: | checkstyle | 1m 15s | phoenix-core: The patch generated 48 new + 734 unchanged - 18 fixed = 782 total (was 752) |
| -1 :x: | whitespace | 0m 0s | The patch 4 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed |
| -1 :x: | spotbugs | 3m 21s | phoenix-core generated 1 new + 972 unchanged - 0 fixed = 973 total (was 972) |
| _ Other Tests _ | |||
| -1 :x: | unit | 161m 45s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 16s | The patch generated 7 ASF License warnings. |
| 230m 39s |
| Reason | Tests |
|---|---|
| FindBugs | module:phoenix-core |
| Class org.apache.phoenix.jdbc.MalformedUrlException is not derived from an Exception, even though it is named as such At MalformedUrlException.java:from an Exception, even though it is named as such At MalformedUrlException.java:[lines 8-15] | |
| Failed junit tests | phoenix.mapreduce.util.PhoenixConfigurationUtilTest |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1280 |
| JIRA Issue | PHOENIX-6523 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 03f2c05daf9d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / f606289 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 486 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1280/10/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
I moved Registry context to a separate package. I think it covers @joshelser's ask of starting to clean up the PhoenixEmbeddedDriver. It's an in-between to where we want to be ideally (@stoty as you pointed out here) vs what we can do now realistically.
Created a class called EmbeddedDriverContext to pass between the EmbeddedDriver and the Registry classes. I tagged in comments with the 🥴 emoji places where the context is passed back and forth (unnecessarily perhaps) - so let me know if we should make any changes there.
I think an integration test would really help here so I'm going to get started on that.
CC: @dbwong @yanxinyi @virajjasani @apurtell
A havily modified version of this already been merged. I suggest closing this one, @ramatronics .