phoenix
phoenix copied to clipboard
Published
20 hours ago •
apache
apache
PHOENIX-5974 add queryId for phoenix queries and propagate to hbase
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ 4.16 Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 13m 57s | 4.16 passed |
| +1 :green_heart: | compile | 1m 1s | 4.16 passed |
| +1 :green_heart: | checkstyle | 1m 37s | 4.16 passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.16 passed |
| +0 :ok: | spotbugs | 2m 59s | phoenix-core in 4.16 has 944 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 5m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 1m 39s | phoenix-core: The patch generated 54 new + 2834 unchanged - 30 fixed = 2888 total (was 2864) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 7s | the patch passed |
| _ Other Tests _ | |||
| -1 :x: | unit | 1m 18s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| 36m 2s |
| Reason | Tests |
|---|---|
| Failed junit tests | phoenix.compile.HavingCompilerTest |
| phoenix.compile.JoinQueryCompilerTest | |
| phoenix.schema.MetaDataClientTest | |
| phoenix.query.ParallelIteratorsSplitTest | |
| phoenix.expression.NullValueTest | |
| phoenix.compile.CreateTableCompilerTest | |
| phoenix.index.VerifySingleIndexRowTest | |
| phoenix.index.IndexUpgradeToolTest | |
| phoenix.util.ScanUtilTest | |
| phoenix.execute.MutationStateTest | |
| phoenix.mapreduce.util.IndexColumnNamesTest | |
| phoenix.expression.RoundFloorCeilExpressionsTest | |
| phoenix.query.ScannerLeaseRenewalTest | |
| phoenix.index.IndexMaintainerTest | |
| phoenix.query.PropertyPolicyProviderTest | |
| phoenix.util.PhoenixEncodeDecodeTest | |
| phoenix.query.QueryPlanTest | |
| phoenix.execute.UnnestArrayPlanTest | |
| phoenix.jdbc.PhoenixPreparedStatementTest | |
| phoenix.mapreduce.index.IndexScrutinyTableOutputTest | |
| phoenix.compile.WhereCompilerTest | |
| phoenix.compile.WhereOptimizerTest | |
| phoenix.hbase.index.covered.NonTxIndexBuilderTest | |
| phoenix.iterate.RowKeyOrderedAggregateResultIteratorTest | |
| phoenix.compile.QueryMetaDataTest | |
| phoenix.compile.SelectStatementRewriterTest | |
| phoenix.query.KeyRangeClipTest | |
| phoenix.compile.ViewCompilerTest | |
| phoenix.compile.StatementHintsCompilationTest | |
| phoenix.query.ExplainPlanTextTest | |
| phoenix.schema.MutationTest | |
| phoenix.util.csv.StringToArrayConverterTest | |
| phoenix.iterate.AggregateResultScannerTest | |
| phoenix.filter.SkipScanBigFilterTest | |
| phoenix.compile.QueryOptimizerTest | |
| phoenix.jdbc.PhoenixDriverTest | |
| phoenix.util.json.JsonUpsertExecutorTest | |
| phoenix.query.OrderByTest | |
| phoenix.compile.LimitCompilerTest | |
| phoenix.util.csv.CsvUpsertExecutorTest | |
| phoenix.schema.RowKeyValueAccessorTest | |
| phoenix.schema.RowKeySchemaTest | |
| phoenix.execute.LiteralResultIteratorPlanTest | |
| phoenix.compile.CursorCompilerTest | |
| phoenix.query.ConnectionlessTest | |
| phoenix.compile.TenantSpecificViewIndexCompileTest | |
| phoenix.index.IndexScrutinyMapperTest | |
| phoenix.util.PhoenixRuntimeTest | |
| phoenix.mapreduce.util.PhoenixConfigurationUtilTest | |
| phoenix.index.PrepareIndexMutationsForRebuildTest | |
| phoenix.compile.PostIndexDDLCompilerTest | |
| phoenix.jdbc.PhoenixResultSetMetadataTest | |
| phoenix.compile.QueryCompilerTest |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1250 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 71bb7a7f22f0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.16 / 7cb4a05 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/1/testReport/ |
| Max. process+thread count | 523 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 5m 19s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ 4.16 Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 14m 9s | 4.16 passed |
| +1 :green_heart: | compile | 1m 2s | 4.16 passed |
| +1 :green_heart: | checkstyle | 1m 38s | 4.16 passed |
| +1 :green_heart: | javadoc | 0m 44s | 4.16 passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in 4.16 has 944 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 5m 38s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| -1 :x: | checkstyle | 1m 39s | phoenix-core: The patch generated 30 new + 2860 unchanged - 4 fixed = 2890 total (was 2864) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 44s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 14s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 191m 52s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| 231m 8s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1250 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 02a4971e2413 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.16 / 7cb4a05 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/2/testReport/ |
| Max. process+thread count | 5014 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 5m 40s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| _ 4.16 Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 20m 17s | 4.16 passed |
| +1 :green_heart: | compile | 1m 6s | 4.16 passed |
| +1 :green_heart: | checkstyle | 1m 13s | 4.16 passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.16 passed |
| +0 :ok: | spotbugs | 3m 15s | phoenix-core in 4.16 has 944 extant spotbugs warnings. |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 11m 47s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 13s | phoenix-core: The patch generated 49 new + 2834 unchanged - 30 fixed = 2883 total (was 2864) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 47s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 29s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 180m 15s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| 232m 2s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1250 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 1b652c55fe85 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.16 / 9caa23c |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/3/testReport/ |
| Max. process+thread count | 5352 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1250/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
Have we looked at the scanId that we already have in BaseResultIterators? Seems to be scarcely used. However, we would want to have a single notion of a queryId, unless needed otherwise.
It also looks like the clients need to set this explicitly? Ideally we would not want the clients going through the internal implementations of phoenix (PhoenixStatement and their derivates in this case). Having phoenix generate the queryId implicitly makes more sense IMO.
The notion also seems useful not only for tracing but also for debugging. At the moment, logging in phoenix is scattered and hard to correlate with the actual query. @ArkenKiran
