phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

PHOENIX-6262 Bulk Load have a bug in lowercase tablename

Open wangchao316 opened this issue 4 years ago • 2 comments

wangchao316 avatar Jan 07 '21 02:01 wangchao316

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 1s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 14m 32s master passed
+1 :green_heart: compile 0m 54s master passed
+1 :green_heart: checkstyle 0m 47s master passed
+1 :green_heart: javadoc 0m 44s master passed
+0 :ok: spotbugs 2m 55s phoenix-core in master has 972 extant spotbugs warnings.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 7m 51s the patch passed
+1 :green_heart: compile 0m 54s the patch passed
+1 :green_heart: javac 0m 54s the patch passed
-1 :x: checkstyle 0m 46s phoenix-core: The patch generated 45 new + 740 unchanged - 116 fixed = 785 total (was 856)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 45s the patch passed
-1 :x: spotbugs 3m 8s phoenix-core generated 2 new + 972 unchanged - 0 fixed = 974 total (was 972)
_ Other Tests _
-1 :x: unit 107m 26s phoenix-core in the patch failed.
-1 :x: asflicense 0m 29s The patch generated 1 ASF License warnings.
144m 29s
Reason Tests
FindBugs module:phoenix-core
Null passed for non-null parameter of org.apache.phoenix.util.PhoenixRuntime.getTable(Connection, String) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(Configuration, CommandLine) Method invoked at AbstractBulkLoadTool.java:of org.apache.phoenix.util.PhoenixRuntime.getTable(Connection, String) in org.apache.phoenix.mapreduce.AbstractBulkLoadTool.loadData(Configuration, CommandLine) Method invoked at AbstractBulkLoadTool.java:[line 284]
Null passed for non-null parameter of new org.apache.phoenix.schema.PTableKey(PName, String) in org.apache.phoenix.util.PhoenixRuntime.getTable(Connection, String) Method invoked at PhoenixRuntime.java:of new org.apache.phoenix.schema.PTableKey(PName, String) in org.apache.phoenix.util.PhoenixRuntime.getTable(Connection, String) Method invoked at PhoenixRuntime.java:[line 458]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1073/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix/pull/1073
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 045ae0c81392 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 5ef5faa
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1073/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1073/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1073/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1073/1/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1073/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 6754 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1073/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jan 07 '21 05:01 stoty

HI @wangchao316 can you add a unit or integration test for your changes?

dbwong avatar Jan 21 '21 17:01 dbwong

Fixed by PHOENIX-6357

stoty avatar Apr 25 '23 12:04 stoty