phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

4.x-PHOENIX-6243

Open fengchen8086 opened this issue 5 years ago • 4 comments

fengchen8086 avatar Dec 15 '20 06:12 fengchen8086

I vertify this patch, that is correct.

wangchao316 avatar Dec 15 '20 07:12 wangchao316

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 4m 38s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 :green_heart: mvninstall 11m 35s 4.x passed
+1 :green_heart: compile 0m 55s 4.x passed
+1 :green_heart: checkstyle 0m 31s 4.x passed
+1 :green_heart: javadoc 0m 43s 4.x passed
+0 :ok: spotbugs 3m 4s phoenix-core in 4.x has 951 extant spotbugs warnings.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 5m 41s the patch passed
+1 :green_heart: compile 0m 57s the patch passed
+1 :green_heart: javac 0m 57s the patch passed
-1 :x: checkstyle 0m 32s phoenix-core: The patch generated 2 new + 53 unchanged - 23 fixed = 55 total (was 76)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 44s the patch passed
+1 :green_heart: spotbugs 3m 12s the patch passed
_ Other Tests _
-1 :x: unit 477m 59s phoenix-core in the patch failed.
+1 :green_heart: asflicense 0m 39s The patch does not generate ASF License warnings.
513m 54s
Reason Tests
Failed junit tests phoenix.end2end.join.HashJoinGlobalIndexIT
phoenix.end2end.index.SaltedIndexIT
phoenix.end2end.AlterTableIT
phoenix.end2end.UpsertSelectIT
phoenix.end2end.index.txn.RollbackIT
phoenix.tx.ParameterizedTransactionIT
phoenix.end2end.AlterTableWithViewsIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1020/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix/pull/1020
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 8ee803fccff8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / c0dd428
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1020/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1020/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1020/1/testReport/
Max. process+thread count 6584 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1020/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Dec 15 '20 15:12 stoty

@fengchen8086 - lots of the test failures look to be timeouts, but could you please look at the HashJoinGlobalIndexIT failures that look to be changing query plans to see if it's related to your change?

gjacoby126 avatar Dec 17 '20 23:12 gjacoby126

@gjacoby126 For these timeouts, I see a message as follows. Are they caused by hbase versions?

Caused by: java.util.concurrent.ExecutionException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.UnknownScannerException: Throwing UnknownScannerException to reset the client scanner state for clients older than 1.4

For HashJoinGlobalIndexIT, I run the test locally and no failure is found. Theoretically this PR would not change anything except the BitValueSet.

fengchen8086 avatar Dec 18 '20 03:12 fengchen8086