phoenix-queryserver icon indicating copy to clipboard operation
phoenix-queryserver copied to clipboard

PHOENIX-4664 Time Python driver tests failing

Open stoty opened this issue 1 year ago • 2 comments

stoty avatar Mar 06 '23 11:03 stoty

This requires uncommitted Phoenix side changes.

stoty avatar Mar 06 '23 11:03 stoty

This requires unreleased Phoenix side changes.

stoty avatar Oct 30 '23 04:10 stoty

I ran the tests locally with python 3.12 and I got this error in test_timestamp:

E           AssertionError: Lists differ: [[1, [93 chars]12, 12, 1, 2)], [4, datetime.datetime(2015, 7,[30 chars]one]] != [[1, [93 chars]12, 13, 1, 2)], [4, datetime.datetime(2015, 7,[30 chars]one]]
E
E           First differing element 2:
E           [3, datetime.datetime(2015, 7, 12, 12, 1, 2)]
E           [3, datetime.datetime(2015, 7, 12, 13, 1, 2)]
E
E             [[1, datetime.datetime(2015, 7, 12, 13, 1, 2, 123000)],
E              [2, None],
E           -  [3, datetime.datetime(2015, 7, 12, 12, 1, 2)],
E           ?                                      ^
E
E           +  [3, datetime.datetime(2015, 7, 12, 13, 1, 2)],
E           ?                                      ^
E
E           -  [4, datetime.datetime(2015, 7, 12, 12, 1, 2, 123000)],
E           ?                                        ------
E
E           +  [4, datetime.datetime(2015, 7, 12, 13, 1, 2, 123000)],
E           ?                                      ++++++
E
E              [5, None]]

phoenixdb/tests/test_types.py:218: AssertionError

richardantal avatar Jul 19 '24 08:07 richardantal

Thank you, it should be fixed with the new commit.

stoty avatar Jul 24 '24 13:07 stoty

merged manually

stoty avatar Jul 25 '24 05:07 stoty