phoenix-connectors icon indicating copy to clipboard operation
phoenix-connectors copied to clipboard
verified publisher icon apache

PHOENIX-6859 Update phoenix5-spark3 README with PySpark code references

Open Abhey opened this issue 2 years ago • 11 comments

This PR introduces the changes for adding the PySpark code references in the phoenix5-spark3 connector README.

Abhey avatar Jan 23 '23 13:01 Abhey

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 6m 18s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
-1 :x: markdownlint 0m 1s The patch generated 30 new + 50 unchanged - 4 fixed = 80 total (was 54)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 :green_heart: asflicense 0m 31s The patch does not generate ASF License warnings.
7m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/92
Optional Tests dupname asflicense markdownlint
uname Linux 8a914290e3a8 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4da44c7
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/1/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: phoenix5-spark3 U: phoenix5-spark3
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/1/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jan 23 '23 13:01 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
-1 :x: markdownlint 0m 2s The patch generated 33 new + 46 unchanged - 8 fixed = 79 total (was 54)
-1 :x: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
_ Other Tests _
+1 :green_heart: asflicense 0m 31s The patch does not generate ASF License warnings.
2m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/92
Optional Tests dupname asflicense markdownlint
uname Linux fdceb27a730b 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4da44c7
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/2/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/2/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: phoenix5-spark3 U: phoenix5-spark3
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/2/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jan 23 '23 13:01 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
-1 :x: markdownlint 0m 2s The patch generated 10 new + 28 unchanged - 26 fixed = 38 total (was 54)
-1 :x: whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
_ Other Tests _
+1 :green_heart: asflicense 0m 30s The patch does not generate ASF License warnings.
2m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/92
Optional Tests dupname asflicense markdownlint
uname Linux fb3451f06b7c 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4da44c7
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/3/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/3/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: phoenix5-spark3 U: phoenix5-spark3
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/3/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jan 23 '23 14:01 stoty

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
-1 :x: markdownlint 0m 1s The patch generated 3 new + 19 unchanged - 35 fixed = 22 total (was 54)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 :green_heart: asflicense 0m 31s The patch does not generate ASF License warnings.
2m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/92
Optional Tests dupname asflicense markdownlint
uname Linux 9e5b71556a5d 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4da44c7
markdownlint https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/4/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: phoenix5-spark3 U: phoenix5-spark3
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/4/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jan 23 '23 16:01 stoty

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 :green_heart: markdownlint 0m 2s The patch generated 0 new + 15 unchanged - 39 fixed = 15 total (was 54)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 :green_heart: asflicense 0m 30s The patch does not generate ASF License warnings.
1m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/phoenix-connectors/pull/92
Optional Tests dupname asflicense markdownlint
uname Linux 822a16ddacb3 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-connectors-personality.sh
git revision master / 4da44c7
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: phoenix5-spark3 U: phoenix5-spark3
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-92/5/console
versions git=2.7.4 maven=3.3.9 markdownlint=0.22.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty avatar Jan 23 '23 16:01 stoty

@virajjasani @tkhurana Please review the PR.

Abhey avatar Jan 23 '23 16:01 Abhey

@stoty you might also be interested in this

virajjasani avatar Jan 23 '23 18:01 virajjasani

Thanks for the PR @Abhey

virajjasani avatar Jan 23 '23 18:01 virajjasani

Would it be possible to add the relevant changes to the Spark2 README ?

stoty avatar Jan 23 '23 18:01 stoty

Thanks, @stoty for reviewing the PR. I will take a look at your review comments and address the same.

Abhey avatar Jan 30 '23 19:01 Abhey

@stoty One question for you, I created a Docker Image with all the Pre-Requisites for testing the Phoenix-Spark connector. Do you think it's a good idea to add the reference to the same in the official documentation?

Repository Link -

  • https://github.com/Abhey/phoenix-spark-connector-demo

Abhey avatar Jan 30 '23 19:01 Abhey