pekko icon indicating copy to clipboard operation
pekko copied to clipboard

investigate ClusterActorLoggingSpec

Open pjfanning opened this issue 2 years ago • 1 comments

possibly related to #771

  • passes on laptop both for 1.0.x and main branches
  • failed in nightly build but passed when rerun
  • seems to pass when nightly build is run using the 1.0.x branch - https://github.com/apache/incubator-pekko/actions/runs/6902135347/job/18778244515

pjfanning avatar Nov 17 '23 08:11 pjfanning

link : https://github.com/apache/incubator-pekko/issues/929

He-Pin avatar Jan 29 '24 13:01 He-Pin

still flaky in nightly builds: https://github.com/apache/pekko/actions/runs/9993956065/job/27622606159

Roiocam avatar Jul 18 '24 16:07 Roiocam

Because sometimes the actor don't put value into MDC:

LoggingEvent(
		INFO,
		org.apache.pekko.cluster.typed.ClusterActorLoggingSpec,
		ClusterActorLoggingSpec-pekko.actor.default-dispatcher-11,
		Starting,
		1721630292397,
		None,	
		None,
+		Map(pekkoAddress -> pekko.tcp://[email protected]:42905, pekkoSource -> pekko://ClusterActorLoggingSpec/user/$a, sourceActorSystem -> ClusterActorLoggingSpec)
)
LoggingEvent(
		INFO,
		org.apache.pekko.cluster.typed.ClusterActorLoggingSpec,
		ClusterActorLoggingSpec-pekko.actor.default-dispatcher-3,
		Starting,
		1721631006935,
		None,
		None,
-		Map()
)

Roiocam avatar Jul 22 '24 07:07 Roiocam

Because sometimes the actor don't put value into MDC

Doesn't that mean the test caught a bug?

raboof avatar Jul 22 '24 09:07 raboof

Doesn't that mean the test caught a bug?

It is flaky depending on how fast SLF4J initialization.

If it loads slower, it will use SubstituteLogger(which uses BasicMDCAdapter) as a fallback.

截屏2024-07-23 09 32 21

if we use MDC earlier than SLF4J initialization, the MDCAdapter may no chance to update it.

image

截屏2024-07-23 09 24 52

Roiocam avatar Jul 23 '24 02:07 Roiocam

won't reopen it because ci is passing: https://github.com/apache/pekko/actions/runs/10076913173/job/27858277926

Roiocam avatar Jul 24 '24 12:07 Roiocam