pekko icon indicating copy to clipboard operation
pekko copied to clipboard

fix: avoid call finalizeStage more times than once. (#1650)

Open He-Pin opened this issue 1 year ago • 6 comments

(cherry picked from commit 7fef5b75f3a4e435f572d870758f364e1d65a84c)

He-Pin avatar Dec 31 '24 12:12 He-Pin

You keep raising PRs against the wrong branch.

image

I don't think this should be merged to 1.1 yet. I am not convinced that this issue is causing major issues and therefore would not justify being added in a patch.

pjfanning avatar Dec 31 '24 12:12 pjfanning

It will cause problems in 1.0.x, but still, it may call twice GraphStageLogic#postStop in 1.1.x, and we are using it at work :(

He-Pin avatar Dec 31 '24 12:12 He-Pin

Can we hold off merging to patch branches for a few days so that the changes can be more widely reviewed?

pjfanning avatar Dec 31 '24 12:12 pjfanning

@pjfanning Okay, Let's do this next weekend.

He-Pin avatar Dec 31 '24 12:12 He-Pin

My preference is not to backfit changes that are not definitely causing major issues. With the main branch, we could start doing milestone releases, eg 1.2.0-M1. We just need more people to get involved in voting on releases.

pjfanning avatar Jan 02 '25 13:01 pjfanning

let's keep this open to see if a user requests it.

He-Pin avatar Jan 02 '25 13:01 He-Pin