pekko icon indicating copy to clipboard operation
pekko copied to clipboard

jdk9 tests do not run

Open pjfanning opened this issue 1 year ago • 1 comments

See https://github.com/apache/pekko/pull/1432 - I deliberately modified 2 classes (1 Java, 1 Scala) to see if they were even compiled. The PR did fail because scalafmt and the doc build failed but the main part of the build where we compile code and run tests - this all ran ok.

pjfanning avatar Aug 08 '24 21:08 pjfanning

I guess sbt dependWalkerCheck didn't want to verify TestJDK9+ classes compile, but I don't remember why it was on purpose.

and it is normal that PRValidationTest does not run JDK9 verification. We will not verify these on the main process, but only verify on binary compability or documentation check

Roiocam avatar Aug 09 '24 03:08 Roiocam

#1434 merged

pjfanning avatar Aug 28 '24 20:08 pjfanning