pekko icon indicating copy to clipboard operation
pekko copied to clipboard

Mark some internal sealed trait @DoNotInherit

Open He-Pin opened this issue 1 year ago • 3 comments

There are classes is not marked with @DoNotInherent, then Java user may extends that classes. We should mark it with @DoNotInherent.

And there are some classes should be annotated with @InternalApi.

refs: https://github.com/apache/pekko-connectors/pull/588

He-Pin avatar Apr 08 '24 03:04 He-Pin

Is @DoNotInherent necessary if the class is final, that is already implied?

Typically @ DoNotInherent is used for classes which can be extended but only for private cases

mdedetrich avatar Apr 08 '24 12:04 mdedetrich

no, I mean we should mark on sealed trait and sealed abstract class

He-Pin avatar Apr 08 '24 12:04 He-Pin

no, I mean we should mark on sealed trait and sealed abstract class

That makes perfect sense, :+1 from me

mdedetrich avatar Apr 08 '24 14:04 mdedetrich