pekko-http icon indicating copy to clipboard operation
pekko-http copied to clipboard

dorny/test-reporter@v1 is not allowed

Open pjfanning opened this issue 8 months ago • 1 comments

dorny/test-reporter@v1 is not allowed to be used in apache/pekko-http. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following: 1Password/load-secrets-action@581a835fb51b8e7ec56b71cf2ffddd7e68bb25e0, AdoptOpenJDK/install-jdk@, BobAnkh/auto-generate-changelog@, DavidAnson/markdownlint-cli2-action@b4c9feab76d8025d1e83c653fa3990936df0e6c8, DavidAnson/markdownlint-cli2-action@v16, EnricoMi/publish-unit-test-result-action@, JamesIves/github-pages-deploy-action@881db5376404c5c8d621010bcbec0310b58d5e29, JamesIves/[email protected], JustinBeckwith/linkinator-action@3d5ba091319fa7b0ac14703761eebb7d100e6f6d, JustinBeckwith/[email protected], Kesin11/actions-timeline@427ee2cf860166e404d0d69b4f2b24012bb7af4f, Madrapps/jacoco-report@fd4800e8a81e21bdf373438e5918b975df041d15, PyO3/maturin-action@, TobKed/label-when-approved-action@*, VirtusLab/scala-cl...

pjfanning avatar Apr 13 '25 10:04 pjfanning

Do we have an example of a PR where the test results were posted to the PR? Did we find it helpful? If we did I'm sure we could find a way, though posting results to PRs requires additional privileges, so there's also something to be said for keeping the workflows simple/unprivileged and dropping this convenience.

raboof avatar Apr 14 '25 08:04 raboof

@raboof I'm happy to remove the CI job that uses this task. I don't think anyone is using the results of this job.

We have a bigger issue. Now that ASF Infra team are trying to get us to stop using wildcards or version numbers for actions and getting us to switch to SHA codes for the actions, we'll have to update all our CI definitions, including in the versioned branches.

pjfanning avatar May 07 '25 21:05 pjfanning

@raboof I'm happy to remove the CI job that uses this task. I don't think anyone is using the results of this job.

#692

We have a bigger issue. Now that ASF Infra team are trying to get us to stop using wildcards or version numbers for actions and getting us to switch to SHA codes for the actions, we'll have to update all our CI definitions

#691

including in the versioned branches.

Perhaps we should consider disabling those until we know we need them? Or do we already know?

raboof avatar Jun 16 '25 11:06 raboof