Attempting to fix issues with printing

[trumpetinc]

see "Guidance on heap space error when printing document" discussion on user listserv

[THausherr]

Why did you change the equals and the hash, is this for optimizing? (Assumption that xform is only scale, never shear)

I tried the scale change from your last commit, this does not work well when setting MAXEDGE at 500. The "Schleuse" file looks very different. The problem is that the pattern gets shorter and is scaled so the repetition is visible, while a crop has no effect as long as the cropped part is outside the page. This can also be seen on page 7 of the file from PDFBOX-3653.pdf .

[trumpetinc]

Yes - it is an optimization. I'm pretty sure you can re-use the cached value if there is only a translation. But please sanity check my logic on this.

This is not the most important optimization for printing - by far the most important optimization is caching of the PageDrawer.

And switching to the weak valued cache in TilingPatternFactory is important as the current cache is going to evict very rapidly.

• K

Kevin Day

*trumpet*p| 480.961.6003 x1002 e| @. www.trumpetinc.com http://trumpetinc.com/ LinkedIn https://www.linkedin.com/company/trumpet-inc.| Trumpet Blog http://trumpetinc.com/blog/| Twitter https://twitter.com/trumpetinc

Proud to be Great Place To Work https://www.greatplacetowork.com/certified-company/7012667 certified since 2019

On Tue, Nov 9, 2021 at 11:06 AM Tilman Hausherr @.***> wrote:

Why did you change the equals and the hash, is this for optimizing? (Assumption that xform is only scale, never shear)

I tried the scale change from your last commit, this does not work well when setting MAXEDGE at 500. The "Schleuse" file looks very different. The problem is that the pattern gets shorter and is scaled so the repetition is visible, while a crop has no effect as long as the cropped part is outside the page. This can also be seen on page 7 of the file from PDFBOX-3653.pdf .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apache/pdfbox/pull/135#issuecomment-964402652, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSP46ECLJQIO6YVMXBUZSDULFPKRANCNFSM5HRCREUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.