parquet-java
parquet-java copied to clipboard
PARQUET-2165: Remove deprecated PathGlobPattern class
Remove the deprecated classes PathGlobPattern and DeprecatedFieldProjectionFilter so that Parquet will compile against hadoop 3.x.
If a thrift reader is configured to use the now-deleted filter, by setting the filter in "parquet.thrift.column.filter", a ThriftProjectionException will be thrown.
Jira
- [X] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
Tests
- [X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
It modifies the test TestParquetToThriftReadWriteAndProjection
to switch to the strict filter in all test cases where the old one was being used.
*these tests now all fail with ThriftProjectionException: No columns have been selected
I could cut the tests "obsolete" but it would seem to me that moving the tests to the strict filter would be better. I will just need help doing this.
Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters (not including Jira issue reference)
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
@steveloughran is this something that you still want to get in?
Seems to conflict with https://github.com/apache/parquet-mr/pull/1076
This needs to be disposed of for building against more recent hadoop versions, so someone has to do it..