parquet-java
parquet-java copied to clipboard
PARQUET-1760: Use SLF4J Logger for TestStatistics
Make sure you have checked all steps below.
Jira
- [X] My PR addresses the following PARQUET-1760 issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-1760
- In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
Tests
- [X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters (not including Jira issue reference)
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
@Fokko Some discussion related to this topic going on with PARQUET-1758
I think the general idea is that all test-related logging is DEBUG level. If a test fails, users can set the Logger to DEBUG level and run the test again to get more detail. It's too noisy when doing a build and no one cares about the flood of text that comes on screen when doing a build. It may be advantageous to setup YETUS so that the automated builds are with DEBUG log enabled, but my feeling is that logging shouldn't be enabled by default for developers.