parquet-java icon indicating copy to clipboard operation
parquet-java copied to clipboard

PARQUET-1758: InternalParquetRecordReader Logging is Too Verbose

Open belugabehr opened this issue 5 years ago • 1 comments

Make sure you have checked all steps below.

Jira

  • [X] My PR addresses the following PARQUET-1758 issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
    • https://issues.apache.org/jira/browse/PARQUET-1758
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

  • [X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • [X] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

belugabehr avatar Jan 12 '20 15:01 belugabehr

+1 (non-binding) this seems sensible to me

dossett avatar Mar 31 '21 15:03 dossett