parquet-java icon indicating copy to clipboard operation
parquet-java copied to clipboard

PARQUET-1597: Fix parquet-cli's wrong or missing usage examples

Open sekikn opened this issue 6 years ago • 0 comments

Make sure you have checked all steps below.

Jira

  • [x] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
    • https://issues.apache.org/jira/browse/PARQUET-1597
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

No additional unit test, since it's just a message fix. I confirmed that all of the existing unit tests passed. Also, I manually ran all examples I fixed and all of them succeeded.

Commits

  • [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • [x] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

sekikn avatar Jun 15 '19 13:06 sekikn