parquet-java icon indicating copy to clipboard operation
parquet-java copied to clipboard

PARQUET-2449: Limit local buffer to be similar to Hadoop writing

Open amousavigourabi opened this issue 1 year ago • 1 comments

Make sure you have checked all steps below.

Jira

  • [ ] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
    • https://issues.apache.org/jira/browse/PARQUET-XXX
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

  • [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • [ ] My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • [ ] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

The implementation mixed up block and buffer sizes

amousavigourabi avatar Mar 14 '24 14:03 amousavigourabi

Could you take a look @wgtmac ?

amousavigourabi avatar Mar 14 '24 14:03 amousavigourabi

@chadselph Could you confirm that it fixes the issue?

wgtmac avatar Mar 15 '24 02:03 wgtmac

Looks better! Thanks

Screenshot 2024-03-20 at 10 38 44

chadselph avatar Mar 20 '24 17:03 chadselph

Thanks for confirming! @chadselph

Good job! @amousavigourabi

wgtmac avatar Mar 21 '24 01:03 wgtmac