parquet-java icon indicating copy to clipboard operation
parquet-java copied to clipboard

PARQUET-2441: Upgrading Spotless to 0.43.0 & Scala to 2.12.19

Open vinooganesh opened this issue 1 year ago • 3 comments

Currently building off of master is broken because of:

[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.30.0:check (default) on project parquet-format-structures: Execution default of goal com.diffplug.spotless:spotless-maven-plugin:2.30.0:check failed: java.lang.reflect.InvocationTargetException: 'com.sun.tools.javac.tree.JCTree com.sun.tools.javac.tree.JCTree$JCImport.getQualifiedIdentifier()' -> [Help 1]

Arrow hit the same issue: https://github.com/apache/arrow-datafusion-comet/pull/85 because of this: https://github.com/diffplug/spotless/issues/1774. Bumping spotless to fix building on master.

It is also broken because of this https://github.com/scala/bug/issues/12783. Scala cut and released a fix that was merged into 2.12.19: https://github.com/scala/scala/pull/10668/commits/9ee7c1e043ff89bffcaab28c8b74feea549f678e.


Jira

  • [X] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"

Tests

  • [X] My PR adds the following unit tests OR does not need testing for this extremely good reason: Library bump

Commits

  • [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • [x] My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • [X] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

vinooganesh avatar Mar 01 '24 17:03 vinooganesh

@shangxinli @Fokko can I get a quick approval for tests?

vinooganesh avatar Mar 01 '24 18:03 vinooganesh

@vinooganesh Could you please fix the CI?

wgtmac avatar Mar 03 '24 13:03 wgtmac

Absolutely, I'll get the tests fixed this week and reping

vinooganesh avatar Mar 04 '24 03:03 vinooganesh

Root caused this as a local issue

vinooganesh avatar Mar 25 '24 13:03 vinooganesh