parquet-format icon indicating copy to clipboard operation
parquet-format copied to clipboard

MINOR: Bump thrift to 0.22.0

Open vinooganesh opened this issue 6 months ago • 5 comments

Bumping thrift: https://github.com/apache/thrift/blob/master/CHANGES.md#0220

vinooganesh avatar May 27 '25 23:05 vinooganesh

@Fokko @wgtmac

vinooganesh avatar May 27 '25 23:05 vinooganesh

Hmm, this is weird, it seems like libthrift hasn't been propagated to maven central yet. Seems like it happened before https://www.mail-archive.com/[email protected]/msg03291.html. We can give it a few days to see if it appears.

vinooganesh avatar May 28 '25 02:05 vinooganesh

It's still not there: https://repo.maven.apache.org/maven2/org/apache/thrift/libthrift/, this is a little surprising. Let me do some more digging.

vinooganesh avatar May 30 '25 14:05 vinooganesh

Someone else is tracking here: https://lists.apache.org/thread/pbghrvn9yt18dnzc7g392zdm564fnjg0

vinooganesh avatar Jun 02 '25 23:06 vinooganesh

Still not there: https://mvnrepository.com/artifact/org.apache.thrift/libthrift

Fokko avatar Jun 25 '25 17:06 Fokko

0.22.0 is finally there! https://repo.maven.apache.org/maven2/org/apache/thrift/libthrift/0.22.0/

vinooganesh avatar Jun 27 '25 01:06 vinooganesh

@wgtmac @Fokko can you approve for tests?

vinooganesh avatar Jun 27 '25 01:06 vinooganesh

@vinooganesh Any time!

Fokko avatar Jun 27 '25 05:06 Fokko

I think the test failure was a blip, @Fokko can you retrigger it?

vinooganesh avatar Jun 27 '25 17:06 vinooganesh

I think the test failure was a blip, @Fokko can you retrigger it?

Done! Let's see if it can succeed.

wgtmac avatar Jun 29 '25 14:06 wgtmac

Thanks @vinooganesh for bumping Thrift, and thanks @wgtmac for the review and triggering of the CI

Fokko avatar Jun 29 '25 14:06 Fokko

Thanks @wgtmac and @Fokko ! Could we release a new parquet-format? I can call for a vote on the list, but I think a committer has to actually run through the formal process

vinooganesh avatar Jun 29 '25 18:06 vinooganesh

I think there isn't any spec change since the last release. Perhaps we can wait for recent discussions (IEEE754 order, int96 stats, interval types, etc.) to close before releasing the next version.

wgtmac avatar Jun 30 '25 01:06 wgtmac