paimon icon indicating copy to clipboard operation
paimon copied to clipboard
verified publisher icon apache

[improvement] Use new ReadBuilder and WriteBuilder API in tests

Open JingsongLi opened this issue 2 years ago • 2 comments

Stop using old interfaces.

JingsongLi avatar Mar 19 '23 02:03 JingsongLi

I want to try it. Could you please assign it to me?

TyrantLucifer avatar Mar 20 '23 03:03 TyrantLucifer

I want to try it. Could you please assign it to me?

Welcome, you can just create PR for this. I think this may need multiple PRs.

JingsongLi avatar Mar 20 '23 04:03 JingsongLi

@JingsongLi, IMO, it's no need to create multiple PRs to solve this issue. @TyrantLucifer, you could create multiple commits for different modules in one PR. Please keep one commit for initial PR.

SteNicholas avatar Mar 27 '23 01:03 SteNicholas

Hi @TyrantLucifer , we don't just use the new ReadBuilder and WriteBuilder APIs either, we need to get rid of the FileStoreTable as well, our best practice is to use Catalog to create the Table and then follow through with the operations.

JingsongLi avatar Mar 28 '23 02:03 JingsongLi

@JingsongLi, IMO, it's no need to create multiple PRs to solve this issue. @TyrantLucifer, you could create multiple commits for different modules in one PR. Please keep one commit for initial PR.

One commit for initial PR? But create multiple commits for different modules in one PR? Can you explain more?

JingsongLi avatar Mar 28 '23 02:03 JingsongLi