paimon icon indicating copy to clipboard operation
paimon copied to clipboard

[Feature] ConfigOption add sinceVersion

Open melin opened this issue 1 year ago • 2 comments

Search before asking

  • [X] I searched in the issues and found nothing similar.

Motivation

ConfigOption add the sinceVersion. Records from which version the parameter was added

Solution

No response

Anything else?

No response

Are you willing to submit a PR?

  • [ ] I'm willing to submit a PR!

melin avatar Sep 14 '24 03:09 melin

Good point!

JingsongLi avatar Sep 17 '24 09:09 JingsongLi

Good point!

This issue seems to be more friendly to newcomers, can I give it a try? I understand that we can refer to the implementation of Spark:

  1. Add a private field version to ConfigOption.
  2. Add a public method sinceVersion to ConfigOption.
  3. Sort out all created ConfigOptions to find out which version the ConfigOption was introduced from. The involved classes are CoreOptions, CatalogOptions, SecurityConfiguration, AbstractIcebergCommitCallback, RocksDBOptions, PrivilegedCatalog, FlinkCatalogOptions, AvroFileFormat, and HiveCatalogOptions.

davedwwang avatar Sep 23 '24 11:09 davedwwang

Good point!

This issue seems to be more friendly to newcomers, can I give it a try? I understand that we can refer to the implementation of Spark:

  1. Add a private field version to ConfigOption.
  2. Add a public method sinceVersion to ConfigOption.
  3. Sort out all created ConfigOptions to find out which version the ConfigOption was introduced from. The involved classes are CoreOptions, CatalogOptions, SecurityConfiguration, AbstractIcebergCommitCallback, RocksDBOptions, PrivilegedCatalog, FlinkCatalogOptions, AvroFileFormat, and HiveCatalogOptions.

Feel free to create PR.

JingsongLi avatar Oct 15 '24 06:10 JingsongLi