paimon icon indicating copy to clipboard operation
paimon copied to clipboard

[core]Fix branchesTable created_from_snapshot field display result error.

Open herefree opened this issue 1 year ago • 6 comments

Purpose

created_from_snapshot should be the origin of the tag,not the earliest snapshot of the branch.

Linked issue: close #xxx

Tests

API and Format

Documentation

herefree avatar Sep 10 '24 09:09 herefree

It is possible that the branches tag does not exist but the snapshot exists?

LinMingQiang avatar Sep 10 '24 10:09 LinMingQiang

It is possible that the branches tag does not exist but the snapshot exists?

Yes, if you create empty branch then insert some data to this branch, or you create branch from tag then delete branch's tag. In above two case snapshot will exists,tag will not exists. In this case created_from_tag will be null. I do not think we should remain created_from_snapshot,because we only support create_branch from tag. Snapshot will expire quickly, it's hard for us to know whether the earliest snapshot of the branch is from the main branch.

herefree avatar Sep 10 '24 11:09 herefree

created_from_snapshot can be the origin of the tag?

LinMingQiang avatar Sep 10 '24 11:09 LinMingQiang

created_from_snapshot can be the origin of the tag?

That's okay, I'll modify it.

herefree avatar Sep 10 '24 12:09 herefree

With the current architecture, we cannot accurately obtain the origin snapshot of the branch. Maybe we should open a discussion thread to discuss this issue.

LinMingQiang avatar Sep 11 '24 03:09 LinMingQiang

With the current architecture, we cannot accurately obtain the origin snapshot of the branch. Maybe we should open a discussion thread to discuss this issue.

I create a issue #4166

herefree avatar Sep 11 '24 06:09 herefree

Can we just delete created_from_tag and created_from_snapshot first?

JingsongLi avatar Oct 15 '24 07:10 JingsongLi

Can we just delete created_from_tag and created_from_snapshot first?

I think it's ok if we can't get the exact tag and snapshot.I'll change it.

herefree avatar Oct 16 '24 02:10 herefree

Can we just delete created_from_tag and created_from_snapshot first?

have changed.

herefree avatar Oct 16 '24 06:10 herefree