[core]IcebergConversions addType for Timestamp and Time
Purpose
Linked issue: close #3788
IcebergConversions addType for Timestamp and Time
Tests
IcebergDataTypeCompatibilityTest
API and Format
Documentation
PostgresSyncTableActionITCase.testOptionsChange » Timeout testOptionsChange()
This timeout check failed, please tell me how to re-check, thank you very much
@tsreaper
@tsreaper please Review code again,thanks
@tsreaper Could you please help me take a look when you have time? Thank you
@tsreaper I am reading the source code now and solved this problem. Please review it for me.
I found that a lot of the core code was written by you. I will learn from you. I think the source code should make me familiar with paimon quickly. I hope this PR will be submitted as soon as possible. I will continue to contribute to the next one.
Hi @dbac , sorry for keeping you waiting. I've just introduced statistics to IcebergDataFileMeta, so now Iceberg will filter files according to the statistics we converted from IcebergConversions, and we can test the conversion reliably.
Please resolve the conflicts and add tests about timestamp and time to IcebergCompatibilityTest#testAllTypeStatistics. More specifically, do not add new test method. Just add a few columns with timestamp and time type to that test.
@tsreaper
time only support 3 pecesion (so, ms ), and use int writer.
so IcebergConversions time value should int not long.
@tsreaper
Is it a bug? Lessthan invalid, greaterthan ok ?
Is there a problem with writing iceberg data?
https://github.com/apache/iceberg/issues/9431
@tsreaper ? Could you help me review it again?
Thanks @dbac for the contribution. @tsreaper has created another version #4318 to solve this issue. Close this PR now.