paimon icon indicating copy to clipboard operation
paimon copied to clipboard

[core] fix the collect of overlapped snapshots

Open Askwang opened this issue 1 year ago • 3 comments

Purpose

When call findOverlappedSnapshots(List<Snapshot> taggedSnapshots, long beginInclusive, long endExclusive). If beginInclusive is 10, endExclusive is 15, the range is [10, 15), and the taggedSnapshots is [8, 9, 11, 12, 15]. In previous way, the overlapped snapshots is [9, 11, 12]. Actually is only [11, 12].

Tests

API and Format

Documentation

Askwang avatar Jul 16 '24 01:07 Askwang

Hi @askwang , can you add test cases?

JingsongLi avatar Jul 16 '24 02:07 JingsongLi

Hi @askwang , can you add test cases?

test added.

Askwang avatar Jul 16 '24 08:07 Askwang

@JingsongLi can you help take a look, ths

Askwang avatar Aug 23 '24 03:08 Askwang

Hi @askwang

Please try not to modify the code solely based on its naming. Instead, identify issues through practical application, as the naming of the code may simply be a previous naming error.

This should include 'previous', which is the safe boundary for checking.

JingsongLi avatar Oct 15 '24 07:10 JingsongLi