paimon icon indicating copy to clipboard operation
paimon copied to clipboard

[core]tag create time nullable

Open eric666666 opened this issue 1 year ago • 6 comments

Purpose

Linked issue: close #3280

Tests

API and Format

Documentation

eric666666 avatar Apr 30 '24 07:04 eric666666

@Zouxxyy @JingsongLi Please have a review.

eric666666 avatar Apr 30 '24 07:04 eric666666

Can we just set new DataField(6, "create_time", new TimestampType(false, 3)) to new DataField(6, "create_time", new TimestampType(3)) and return null directly? @JingsongLi Okay, I push a new commit with your thoughts. And it works.

+-------------+-----------+---------+-----------------------+------------+--------+-----------+-------------+
|tag_name     |snapshot_id|schema_id|commit_time            |record_count|branches|create_time|time_retained|
+-------------+-----------+---------+-----------------------+------------+--------+-----------+-------------+
|2024-04-29 15|1          |0        |2024-04-29 16:39:58.639|2531        |[]      |null       |             |
|2024-04-29 18|19         |0        |2024-04-29 16:51:00.805|2542        |[]      |null       |             |
|2024-04-29 21|49         |0        |2024-04-29 17:04:05.326|2556        |[]      |null       |             |
+-------------+-----------+---------+-----------------------+------------+--------+-----------+-------------+

eric666666 avatar Apr 30 '24 09:04 eric666666

@eric666666 good new!

JingsongLi avatar Apr 30 '24 10:04 JingsongLi

@eric666666 good new!

@JingsongLi I forgot check format violations,and I just repaired it, please trigger workflows again.

eric666666 avatar Apr 30 '24 10:04 eric666666

Please fix TagsTableTest.testTagsTable.

JingsongLi avatar Apr 30 '24 12:04 JingsongLi

Please fix TagsTableTest.testTagsTable.

@JingsongLi Okay, next time I will pay attention to running the test class locally first.

eric666666 avatar Apr 30 '24 13:04 eric666666

+1

JingsongLi avatar May 04 '24 02:05 JingsongLi