HDDS-13232. Remove duplicate code in DirectoryDeletingService

[frankvicky]

What changes were proposed in this pull request?

DirectoryDeletingService#optimizeDirDeletesAndSubmitRequest and DirectoryDeletingService#processDeletedDirectories have duplicate code snippets. This patch refactors both methods and eliminates the duplicate part.

Please describe your PR in detail: This patch has extracted a helper method processDirectoryRequests and a static inner class ProcessDirectoryResult to reduce duplicate code.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13232

How was this patch tested?

Given that it's just a refactor, the patch won't have any new test cases, and the existing tests should pass.

[jojochuang]

Hi thanks for working on this. Please run the command

./hadoop-ozone/dev-support/checks/checkstyle.sh

to verify checkstyle issues locally.

[adoroszlai]

Thanks @frankvicky for the patch. Currently there are some integration test failures that slipped into master while CI status reporting was broken. Once issues on master are fixed, we'll update this PR to get real test results.

In the meantime, please take a look at the failure in TestDirectoryDeletingServiceWithFSO.

[adoroszlai]

@frankvicky please enable the build-branch workflow in your fork.

[frankvicky]

@adoroszlai: Thanks for the reminder 🙇🏼

[adoroszlai]

TestKeyDeletingService$Normal failed (maybe some flakiness is being introduced)

[github-actions[bot]]

This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.

[adoroszlai]

@aryangupta1998 @swamirishi can you please help resolve conflicts?

@jojochuang can you please review after conflicts are resolved?

[swamirishi]

This IMO feels like forceful refactoring than a natural code progression. But I agree to the fact the curren code could be structured better. Let me see what we can do here

[github-actions[bot]]

This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.

[github-actions[bot]]

Thank you for your contribution. This PR is being closed due to inactivity. If needed, feel free to reopen it.