ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-11509. logging improvements for directory deletion

Open Tejaskriya opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

All Ozone components involved in background deletion should follow consistent patterns with their logging: At the end of each run, and INFO log should display how many items were processed, what the current limit of items per run is, and how long it took. After each run, a DEBUG log should indicate each individual item that was processed.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11509

How was this patch tested?

Tejaskriya avatar Oct 14 '24 19:10 Tejaskriya

Thanks, @Tejaskriya for the patch. Regarding the master jira, I anticipate significant changes to the deletion code. So, I think we should address the logging improvement JIRA later to make sure the logging can be implemented more effectively.

aryangupta1998 avatar Oct 15 '24 20:10 aryangupta1998

@ashishkumar50 @aryangupta1998 Could you please review the patch when you get some time?

Tejaskriya avatar Nov 12 '24 05:11 Tejaskriya

Thanks for the reviews @aryangupta1998 @sumitagrawl @errose28. I have removed the warn logs due to the comments and addressed the other comments. Could you please take another look?

Tejaskriya avatar Dec 16 '24 17:12 Tejaskriya

Thanks for the review @sumitagrawl, I have addressed the comments!

Tejaskriya avatar Dec 18 '24 08:12 Tejaskriya